Only run suggest-reviewers on PR open, not on every push#4791
Merged
simonfaltum merged 1 commit intomainfrom Mar 19, 2026
Merged
Only run suggest-reviewers on PR open, not on every push#4791simonfaltum merged 1 commit intomainfrom
simonfaltum merged 1 commit intomainfrom
Conversation
Remove the `synchronize` trigger so the action does not re-run when commits are pushed to an already-open PR. Co-authored-by: Isaac
simonfaltum
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
Eligible reviewersCould not determine reviewers from git history. Based on CODEOWNERS, these people or teams could review: @andrewnester, @anton-107, @denik, @pietern, @shreyas-goenka Suggestions based on git history of 1 changed files (0 scored). See CODEOWNERS for path-specific ownership rules. |
chrisst
approved these changes
Mar 19, 2026
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: aae264c
47 interesting tests: 18 RECOVERED, 11 flaky, 9 KNOWN, 5 FAIL, 3 BUG, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
suggest-reviewersaction was re-triggering on every push to an open PR because thesynchronizeevent type was included. This caused unnecessary re-runs after the PR was already reviewed/approved.Changes
Remove the
synchronizetrigger type from the workflow. The action now only runs onopenedandready_for_reviewevents, so it fires once when a PR is created (or when a draft is marked ready) and never re-runs on subsequent pushes.Test plan
if: !github.event.pull_request.draftguard still correctly skips draft PRs.